Give the configuration context precedence over context in integrations #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows users to opt out of automatic context setting without having to set their own context for all events
kattrali
approved these changes
Aug 25, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
If
Configuration#contextis set then it will now take precedence over the context set by integrations. This is true even if it is set tonil, in which case no context will be sent by the notifier — the context will be set by the Bugsnag app insteadFor example:
The top error has
config.context = nil, so the context is set by the Bugsnag appThe middle error has
config.context = 'some context'and so always uses that value as the contextThe bottom error has no context set in
config, which allows the Rack integration's context to be used